Bug 225454

Summary: [GStreamer] Fallback to texture mapper video orientation handling when glvideoflip is not available
Product: WebKit Reporter: Philippe Normand <pnormand>
Component: PlatformAssignee: Philippe Normand <pnormand>
Status: RESOLVED FIXED    
Severity: Normal CC: aperez, calvaris, cgarcia, dkolesa, eric.carlson, ews-watchlist, glenn, gustavo, jer.noble, menard, philipj, sergio, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225456
Attachments:
Description Flags
Patch none

Description Philippe Normand 2021-05-06 06:41:38 PDT
.
Comment 1 Philippe Normand 2021-05-06 07:06:52 PDT
Created attachment 427882 [details]
Patch
Comment 2 Daniel Kolesa 2021-05-06 07:28:49 PDT
confirmed working here
Comment 3 Adrian Perez 2021-05-06 07:50:47 PDT
Patch looked reasonable to me, so it's great that someone with more
multimedia experience like Xabier r+'d this (thanks!) — I will get
this backported to the 2.32 release branch as soon as it lands on
trunk :)
Comment 4 EWS 2021-05-06 08:04:27 PDT
Committed r277088 (237391@main): <https://commits.webkit.org/237391@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427882 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-06 08:05:19 PDT
<rdar://problem/77606997>
Comment 6 Xabier Rodríguez Calvar 2021-05-06 08:15:22 PDT
(In reply to Adrian Perez from comment #3)
> Patch looked reasonable to me, so it's great that someone with more
> multimedia experience like Xabier r+'d this (thanks!) — I will get
> this backported to the 2.32 release branch as soon as it lands on
> trunk :)

I'm as "fast finger".
Comment 7 Adrian Perez 2021-05-06 08:39:11 PDT
(In reply to Xabier Rodríguez Calvar from comment #6)
> (In reply to Adrian Perez from comment #3)
> > Patch looked reasonable to me, so it's great that someone with more
> > multimedia experience like Xabier r+'d this (thanks!) — I will get
> > this backported to the 2.32 release branch as soon as it lands on
> > trunk :)
> 
> I'm as "fast finger".

…aaand this is now in the 2.32 release branch as r277090 =)