Bug 225454 - [GStreamer] Fallback to texture mapper video orientation handling when glvideoflip is not available
Summary: [GStreamer] Fallback to texture mapper video orientation handling when glvide...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-06 06:41 PDT by Philippe Normand
Modified: 2021-05-06 08:39 PDT (History)
14 users (show)

See Also:

Attachments
Patch (5.72 KB, patch)
2021-05-06 07:06 PDT, Philippe Normand 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2021-05-06 06:41:38 PDT 
.
Comment 1 Philippe Normand 2021-05-06 07:06:52 PDT 
Created attachment 427882 [details]
Patch
Comment 2 Daniel Kolesa 2021-05-06 07:28:49 PDT 
confirmed working here
Comment 3 Adrian Perez 2021-05-06 07:50:47 PDT 
Patch looked reasonable to me, so it's great that someone with more
multimedia experience like Xabier r+'d this (thanks!) — I will get
this backported to the 2.32 release branch as soon as it lands on
trunk :)
Comment 4 EWS 2021-05-06 08:04:27 PDT 
Committed r277088 (237391@main): <https://commits.webkit.org/237391@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427882 [details].
Comment 5 Radar WebKit Bug Importer 2021-05-06 08:05:19 PDT 
<rdar://problem/77606997>
Comment 6 Xabier Rodríguez Calvar 2021-05-06 08:15:22 PDT 
(In reply to Adrian Perez from comment #3)
> Patch looked reasonable to me, so it's great that someone with more
> multimedia experience like Xabier r+'d this (thanks!) — I will get
> this backported to the 2.32 release branch as soon as it lands on
> trunk :)

I'm as "fast finger".
Comment 7 Adrian Perez 2021-05-06 08:39:11 PDT 
(In reply to Xabier Rodríguez Calvar from comment #6)
> (In reply to Adrian Perez from comment #3)
> > Patch looked reasonable to me, so it's great that someone with more
> > multimedia experience like Xabier r+'d this (thanks!) — I will get
> > this backported to the 2.32 release branch as soon as it lands on
> > trunk :)
> 
> I'm as "fast finger".

…aaand this is now in the 2.32 release branch as r277090 =)