Bug 225452

Summary: Use IPC::Semaphore instead of sending an IPC message for every captured audio sample
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description youenn fablet 2021-05-06 05:04:11 PDT 
Use IPC::Semaphore instead of sending an IPC message for every captured audio sample
Comment 1 youenn fablet 2021-05-06 05:07:38 PDT 
Created attachment 427873 [details]
Patch
Comment 2 youenn fablet 2021-05-06 05:47:58 PDT 
I reused the web audio model but this might not be an optimal approach given we use chunks of 128 samples, while the AudioUnit may use larger chunks.
Another approach would be to keep using fixed sample size, say 5 or 10 ms, something like std::max(128, sampleRate / 100).
Thoughts?
Comment 3 youenn fablet 2021-05-06 06:27:41 PDT 
Created attachment 427879 [details]
Patch
Comment 4 youenn fablet 2021-05-06 06:28:46 PDT 
Created attachment 427880 [details]
Patch
Comment 5 youenn fablet 2021-05-06 08:21:34 PDT 
Created attachment 427887 [details]
Patch
Comment 6 youenn fablet 2021-05-07 08:45:07 PDT 
Created attachment 428000 [details]
Patch
Comment 7 youenn fablet 2021-05-07 09:45:32 PDT 
Created attachment 428004 [details]
Patch
Comment 8 EWS 2021-05-10 00:10:38 PDT 
Committed r277256 (237525@main): <https://commits.webkit.org/237525@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 428004 [details].
Comment 9 Radar WebKit Bug Importer 2021-05-10 00:11:16 PDT 
<rdar://problem/77731343>