Summary: | Don't allow :visited link style in subtrees that use mix-blend-mode | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||||||||||||
Component: | CSS | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | changseok, commit-queue, darin, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr | ||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=260537 | ||||||||||||||||||
Bug Depends on: | 225698 | ||||||||||||||||||
Bug Blocks: | |||||||||||||||||||
Attachments: |
|
Description
Antti Koivisto
2021-05-06 03:27:50 PDT
Created attachment 427868 [details]
patch
Created attachment 427877 [details]
patch
Created attachment 427886 [details]
patch
Comment on attachment 427886 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=427886&action=review > Source/WebCore/rendering/style/RenderStyle.h:827 > + void setBlendMode(BlendMode mode) > + { > + SET_VAR(m_rareNonInheritedData, effectiveBlendMode, static_cast<unsigned>(mode)); > + SET_VAR(m_rareInheritedData, isInSubtreeWithBlendMode, mode != BlendMode::Normal); > + } I find these multi-line function bodies inside class definitions make it hard for me to get an overview of what’s in the class. Would you consider moving the inline function body below the class definition? Created attachment 428263 [details]
patch
Committed r277320 (237579@main): <https://commits.webkit.org/237579@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428263 [details]. Created attachment 428272 [details]
windows build fix
build fix Committed r277329 (237588@main): <https://commits.webkit.org/237588@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428272 [details]. Re-opened since this is blocked by bug 225698 Created attachment 428617 [details]
patch
reland with test disabled on windows
Created attachment 428716 [details]
patch
Committed r277538 (237766@main): <https://commits.webkit.org/237766@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428716 [details]. |