Bug 225443

Summary: will-change: position should not create a containing block for position: fixed elements
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: Layout and RenderingAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.chromium.org/p/chromium/issues/detail?id=1205953
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Tim Nguyen (:ntim)
Reported 2021-05-06 02:30:34 PDT
Not sure why tbh, but Chrome & Edge also fail here. Only Firefox passes.
Attachments
Patch (5.25 KB, patch)
2021-05-16 02:01 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2021-05-16 09:31 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (6.34 KB, patch)
2021-05-16 09:35 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Patch (6.26 KB, patch)
2021-05-16 09:37 PDT, Tim Nguyen (:ntim) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 2 2021-05-13 02:31:17 PDT
<rdar://problem/77958400>
Tim Nguyen (:ntim)
Comment 3 2021-05-16 01:49:01 PDT
I got some clarification from Emilio: No value of `position` triggers a containing block for a position: fixed; child element, so `will-change: position` also shouldn't trigger a containing block.
Tim Nguyen (:ntim)
Comment 4 2021-05-16 02:01:02 PDT
Created attachment 428779 [details] Patch
Simon Fraser (smfr)
Comment 5 2021-05-16 08:26:59 PDT
Comment on attachment 428779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=428779&action=review > Source/WebCore/ChangeLog:8 > + Marked relevant WPT as pass. Please write more words here about how you are undoing a previous change. Reference that other commit, and reference the test that is exercising the change.
Tim Nguyen (:ntim)
Comment 6 2021-05-16 09:31:21 PDT
Created attachment 428791 [details] Patch
Tim Nguyen (:ntim)
Comment 7 2021-05-16 09:35:59 PDT
Created attachment 428792 [details] Patch
Tim Nguyen (:ntim)
Comment 8 2021-05-16 09:37:54 PDT
Created attachment 428793 [details] Patch
EWS
Comment 9 2021-05-17 03:09:11 PDT
Committed r277579 (237806@main): <https://commits.webkit.org/237806@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428793 [details].
Note You need to log in before you can comment on or make changes to this bug.