Bug 225416

Summary: imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on some platforms
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, darin, ggaren, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=56942
Attachments:
Description Flags
Patch
none
Patch youennf: review+

Description Chris Dumez 2021-05-05 14:09:12 PDT
imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on some platforms:
DIFF:
+CONSOLE MESSAGE: EventSource's response has a charset ("windows-1252") that is not UTF-8. Aborting the connection.
 
-PASS EventSource: always UTF-8
+FAIL EventSource: always UTF-8 assert_unreached: Got error event Reached unreachable code
Comment 1 Chris Dumez 2021-05-05 14:09:23 PDT
<rdar://77529801>
Comment 2 Radar WebKit Bug Importer 2021-05-05 14:09:33 PDT
<rdar://problem/77574516>
Comment 3 Chris Dumez 2021-05-05 14:21:43 PDT
Created attachment 427808 [details]
Patch
Comment 4 Chris Dumez 2021-05-05 19:59:56 PDT
Created attachment 427843 [details]
Patch
Comment 5 youenn fablet 2021-05-05 23:57:43 PDT
Comment on attachment 427843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427843&action=review

> Source/WebCore/ChangeLog:3
> +        imported/w3c/web-platform-tests/eventsource/format-utf-8.htm

Title could be improved
Comment 6 Chris Dumez 2021-05-06 07:49:29 PDT
(In reply to youenn fablet from comment #5)
> Comment on attachment 427843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427843&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        imported/w3c/web-platform-tests/eventsource/format-utf-8.htm
> 
> Title could be improved

LOL, not sure what happened there :o)
Comment 7 Chris Dumez 2021-05-06 07:52:20 PDT
Committed r277087 (237390@main): <https://commits.webkit.org/237390@main>
Comment 8 Alexey Proskuryakov 2021-05-06 18:23:23 PDT
Yay to changing specs! </sarcasm>

cf. bug 56942.