Bug 225416 - imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on some platforms
Summary: imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on so...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-05-05 14:09 PDT by Chris Dumez
Modified: 2021-05-06 18:23 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.76 KB, patch)
2021-05-05 14:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.42 KB, patch)
2021-05-05 19:59 PDT, Chris Dumez 		youennf: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2021-05-05 14:09:12 PDT 
imported/w3c/web-platform-tests/eventsource/format-utf-8.htm is failing on some platforms:
DIFF:
+CONSOLE MESSAGE: EventSource's response has a charset ("windows-1252") that is not UTF-8. Aborting the connection.
 
-PASS EventSource: always UTF-8
+FAIL EventSource: always UTF-8 assert_unreached: Got error event Reached unreachable code
Comment 1 Chris Dumez 2021-05-05 14:09:23 PDT 
<rdar://77529801>
Comment 2 Radar WebKit Bug Importer 2021-05-05 14:09:33 PDT 
<rdar://problem/77574516>
Comment 3 Chris Dumez 2021-05-05 14:21:43 PDT 
Created attachment 427808 [details]
Patch
Comment 4 Chris Dumez 2021-05-05 19:59:56 PDT 
Created attachment 427843 [details]
Patch
Comment 5 youenn fablet 2021-05-05 23:57:43 PDT 
Comment on attachment 427843 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427843&action=review

> Source/WebCore/ChangeLog:3
> +        imported/w3c/web-platform-tests/eventsource/format-utf-8.htm

Title could be improved
Comment 6 Chris Dumez 2021-05-06 07:49:29 PDT 
(In reply to youenn fablet from comment #5)
> Comment on attachment 427843 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427843&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        imported/w3c/web-platform-tests/eventsource/format-utf-8.htm
> 
> Title could be improved

LOL, not sure what happened there :o)
Comment 7 Chris Dumez 2021-05-06 07:52:20 PDT 
Committed r277087 (237390@main): <https://commits.webkit.org/237390@main>
Comment 8 Alexey Proskuryakov 2021-05-06 18:23:23 PDT 
Yay to changing specs! </sarcasm>

cf. bug 56942.