Bug 225393

Summary: USE_64KB_PAGE_BLOCK build option is broken
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: CMakeAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Linux   
See Also: https://bugs.webkit.org/show_bug.cgi?id=217989
Attachments:
Description Flags
Patch none

Description Michael Catanzaro 2021-05-05 05:30:42 PDT 
This option has been broken since I added it in bug #217989. It does properly configure the various JSC and bmalloc options, but doesn't get passed on from CMake to the actual build, so we wind up configuring a 4 KB max page size in PageBlock.h. Oops.
Comment 1 Michael Catanzaro 2021-05-05 05:31:29 PDT 
Created attachment 427759 [details]
Patch
Comment 2 Michael Catanzaro 2021-05-05 05:42:52 PDT 
CC: Adrian, this would be a good backport for 2.32.
Comment 3 EWS 2021-05-05 06:39:18 PDT 
Committed r277015 (237331@main): <https://commits.webkit.org/237331@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427759 [details].