Bug 225375

Summary: [macOS] Use system colors for ActiveButtonText
Product: WebKit Reporter: Aditya Keerthi <akeerthi>
Component: FormsAssignee: Aditya Keerthi <akeerthi>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch for EWS
none
Patch
thorton: review+
Patch for landing none

Aditya Keerthi
Reported 2021-05-04 17:46:16 PDT
...
Attachments
Patch for EWS (1.96 KB, patch)
2021-05-04 17:48 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Patch (3.12 KB, patch)
2021-05-05 12:43 PDT, Aditya Keerthi 		thorton: review+
DetailsFormatted DiffDiff
Patch for landing (3.40 KB, patch)
2021-05-05 13:39 PDT, Aditya Keerthi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Aditya Keerthi
Comment 1 2021-05-04 17:46:39 PDT
<rdar://problem/75863443>
Aditya Keerthi
Comment 2 2021-05-04 17:48:06 PDT
Created attachment 427716 [details] Patch for EWS
Aditya Keerthi
Comment 3 2021-05-05 12:43:26 PDT
Created attachment 427790 [details] Patch
Tim Horton
Comment 4 2021-05-05 13:11:40 PDT
Comment on attachment 427790 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427790&action=review > Source/WebCore/rendering/RenderThemeMac.mm:414 > + if ([cell interiorBackgroundStyle] == NSBackgroundStyleEmphasized) Should also have a FIXME and an AppKit radar on all of this.
Aditya Keerthi
Comment 5 2021-05-05 13:39:56 PDT
Created attachment 427801 [details] Patch for landing
EWS
Comment 6 2021-05-05 19:34:36 PDT
Committed r277067 (237370@main): <https://commits.webkit.org/237370@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427801 [details].
Simon Fraser (smfr)
Comment 7 2021-05-05 21:23:28 PDT
Comment on attachment 427801 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=427801&action=review > Source/WebCore/rendering/RenderThemeMac.mm:423 > + auto cell = adoptNS([[NSButtonCell alloc] init]); > + [cell setBezelStyle:NSBezelStyleRounded]; > + [cell setHighlighted:YES]; > + > + NSColor *activeButtonTextColor; > + if ([cell interiorBackgroundStyle] == NSBackgroundStyleEmphasized) > + activeButtonTextColor = [NSColor alternateSelectedControlTextColor]; > + else > + activeButtonTextColor = [NSColor controlTextColor]; > + > + return semanticColorFromNSColor(activeButtonTextColor); Do we call this every time we paint a button? Can we cache it?
Tim Horton
Comment 8 2021-05-05 23:15:13 PDT
(In reply to Simon Fraser (smfr) from comment #7) > Comment on attachment 427801 [details] > Patch for landing > Do we call this every time we paint a button? Can we cache it? See the changelog :)
Note You need to log in before you can comment on or make changes to this bug.