Bug 22536

Summary: Regression - QtWebKit MinGW port build failure
Product: WebKit Reporter: Laszlo Gombos <laszlo.gombos>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, vestbo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Fix
vestbo: review-
Revised patch based on comment #4 vestbo: review+

Laszlo Gombos
Reported 2008-11-27 19:11:55 PST
Build failure in QtWebKit using MinGW port - I have seen the failure on Win using MinGW, but it could inpact other Qt platforms as well. Regression introduced in Changeset 36623 and inpacted both the wx and Qt port. Regression in wx port is fixed in Changeset 36717, but QT WebKit regression is still there.
Attachments
Fix (1.71 KB, patch)
2008-11-27 19:21 PST, Laszlo Gombos 		vestbo: review-
DetailsFormatted DiffDiff
Revised patch based on comment #4 (2.29 KB, patch)
2008-11-28 09:14 PST, Laszlo Gombos 		vestbo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1 2008-11-27 19:15:53 PST
It would be more useful if you included some information about what the failure is.
Laszlo Gombos
Comment 2 2008-11-27 19:21:58 PST
Created attachment 25563 [details] Fix
Laszlo Gombos
Comment 3 2008-11-27 19:25:10 PST
Mark, compiler under MinGW ends up trying to compile .h files, because they are listed as SOURCE files in the WebCore.pro. DO not have the actual error message handy.
Tor Arne Vestbø
Comment 4 2008-11-28 08:41:57 PST
Maybe add the removed headers to HEADERS?
Laszlo Gombos
Comment 5 2008-11-28 09:14:34 PST
Created attachment 25574 [details] Revised patch based on comment #4 Instead of removing the headers in question from SOURCES, I moved them to HEADERS.
Tor Arne Vestbø
Comment 6 2008-11-28 10:51:48 PST
Good stuff! Landed in r38832
Note You need to log in before you can comment on or make changes to this bug.