Bug 225336

Summary: Inclusive terminology: Change 'master key' to 'main key'
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED INVALID    
Severity: Normal CC: bdakin, bfulgham, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review-

Description Brent Fulgham 2021-05-03 16:40:20 PDT 
In support of using more inclusive language in WebKit, we should switch the term 'Master Key' to 'Main Key'.
Comment 1 Brent Fulgham 2021-05-03 16:44:07 PDT 
<rdar://problem/70995449>
Comment 2 Brent Fulgham 2021-05-03 16:45:24 PDT 
Created attachment 427618 [details]
Patch
Comment 3 Alexey Proskuryakov 2021-05-03 17:21:49 PDT 
Comment on attachment 427618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427618&action=review

> Source/WebCore/ChangeLog:9
> +        Change the text 'Master Key' to 'Main Key' in messages and labels.

Will this invalidate all data encrypted with this key? What exactly will the user impact be?
Comment 4 Brent Fulgham 2021-05-03 17:31:48 PDT 
Comment on attachment 427618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427618&action=review

>> Source/WebCore/ChangeLog:9
>> +        Change the text 'Master Key' to 'Main Key' in messages and labels.
> 
> Will this invalidate all data encrypted with this key? What exactly will the user impact be?

I don't think this will invalidate the key data, but looking further it does seem like we would lose access to the existing keychain, so we probably need a migration step.
Comment 5 Brent Fulgham 2021-09-20 09:50:57 PDT 
After review, it was decided that this change was not needed.