Bug 225283

Summary: glib-genmarshal generated BrowserMarshal.[ch] contained referenced to sourcedir
Product: WebKit Reporter: Khem Raj <raj.khem>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clopez, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
fix-v1 none

Khem Raj
Reported 2021-05-02 13:06:06 PDT
There are references to build time source folder in comments in generated sourcecode BrowserMarshal.c/BrowserMarshal.h, these sources do end up in debug packages (ipks/debs/rpms) which ends up breaking reproducible builds. We can use --skip-source cmdline option to glib-genmarshal to not including the source path in the generated header/source files.
Attachments
fix-v1 (1.60 KB, patch)
2021-05-02 13:09 PDT, Khem Raj 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Khem Raj
Comment 1 2021-05-02 13:09:03 PDT
Created attachment 427531 [details] fix-v1
Carlos Alberto Lopez Perez
Comment 2 2021-05-09 11:45:08 PDT
Comment on attachment 427531 [details] fix-v1 thanks!
EWS
Comment 3 2021-05-09 12:11:29 PDT
Committed r277252 (237521@main): <https://commits.webkit.org/237521@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427531 [details].
Radar WebKit Bug Importer
Comment 4 2021-05-09 12:12:15 PDT
<rdar://problem/77718052>
Note You need to log in before you can comment on or make changes to this bug.