Bug 225274

Summary: editing/selection/ios/become-key-window-when-focusing-editable-area.html is timing out
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: Tools / TestsAssignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: hi, megan_gardner, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
For EWS
none
Patch
none
Add a comment none

Wenson Hsieh
Reported 2021-05-01 14:01:23 PDT
rdar://77042575
Attachments
For EWS (2.84 KB, patch)
2021-05-01 14:03 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Patch (4.63 KB, patch)
2021-05-01 15:45 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Add a comment (4.87 KB, patch)
2021-05-01 17:41 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2021-05-01 14:03:22 PDT Comment hidden (obsolete)
Wenson Hsieh
Comment 2 2021-05-01 15:45:14 PDT
Created attachment 427514 [details] Patch
Sam Weinig
Comment 3 2021-05-01 17:29:22 PDT
Comment on attachment 427514 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427514&action=review > Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:251 > + if (!m_otherWindow) { > + m_otherWindow = adoptNS([[UIWindow alloc] initWithWindowScene:m_window.windowScene]); > + [m_otherWindow setFrame:CGRectMake(-1, -1, 1, 1)]; > + } > + [m_otherWindow setHidden:NO]; > + [m_otherWindow makeKeyWindow]; This seems mysterious enough to warrant a comment explaining what is going on here.
Wenson Hsieh
Comment 4 2021-05-01 17:41:20 PDT
Created attachment 427516 [details] Add a comment
EWS
Comment 5 2021-05-03 11:35:31 PDT
Committed r276912 (237256@main): <https://commits.webkit.org/237256@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427516 [details].
Note You need to log in before you can comment on or make changes to this bug.