Summary: | Remove Windows Cairo Build Dependencies on Non-Redistributable Libraries | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | ||||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Mac | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Brent Fulgham
2008-11-26 22:22:55 PST
Created attachment 25553 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
Patch to Visual Studio project so that the Cairo build does not link against CoreFoundation.dll, CoreGraphics.dll, CFnetwork.dll, or the QuickTime dll.
Comment on attachment 25553 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
r=me, but I think that some include paths could be also removed from both WebKit.vcproj and WebCore.vcproj for consistency.
I'm generating a new patch which removes the QuickTime header path. The remaining CF stuff is still used, as I am now using CFLite, and may (soon) be using CFNetwork APSL version. Created attachment 25560 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
Revised to do the following:
1. Removes non-redistributable include paths (generaly, just QuickTime) from the WebCore project. No longer attempts to build the QuickTime video handling objects.
2. No longer builds the QuickTime library for Cairo_Release/Cairo_Debug
3. Removes linking commands for non-redistributable libraries from WebKit.dll
(In reply to comment #4) Completed build of regular Windows (CG) and confirmed this change does not prevent normal function of features in standard Windows build. Comment on attachment 25560 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
r=me, but please add WebKit.sln to ChangeLog.
Created attachment 25598 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
Include WebKit.sln change in the ChangeLog
Comment on attachment 25598 [details]
Remove CFNetwork, CoreFoundation, CoreGraphics, and Quicktime link
r=me
Committed revision 38847. |