|Summary:||Consider removing imported/w3c/canvas and canvas/philip|
|Product:||WebKit||Reporter:||Sam Weinig <sam>|
|Component:||Canvas||Assignee:||Sam Weinig <sam>|
|Severity:||Normal||CC:||aakash_jain, darin, dino, sabouhallawa, simon.fraser, webkit-bug-importer|
Description Sam Weinig 2021-05-01 08:31:42 PDT
It looks like the layout tests in imported/w3c/canvas and canvas/philip are an out of date subset of the tests in imported/w3c/web-platform-tests/html/canvas/element. I think we should consider removing them to avoid the unnecessary overhead during testing.
Comment 1 Sam Weinig 2021-05-01 08:32:25 PDT
Simon/Dean, do either of you have opinions on this?
Comment 2 Sam Weinig 2021-05-01 08:42:09 PDT
I would like to come up with a way to figure out which tests are actually identical, but the changes in test runners between the 3 copies makes this harder than one would like.
Comment 3 Simon Fraser (smfr) 2021-05-01 10:21:15 PDT
I support their removal.
Comment 5 Sam Weinig 2021-05-01 16:14:23 PDT
3.2 mb may be to big for the bots.
Comment 6 Sam Weinig 2021-05-01 17:31:01 PDT
Created attachment 427515 [details] Part 1 (just canvas/philip)
Comment 7 Sam Weinig 2021-05-01 17:31:45 PDT
Breaking this in two to see if that makes the bots any happier.
Comment 8 Sam Weinig 2021-05-02 08:46:27 PDT
(In reply to Sam Weinig from comment #7) > Breaking this in two to see if that makes the bots any happier. Alas, they are not. It seems there is something in the patch file that is making them unhappy. patching file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html Hunk #1 FAILED at 1. File LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html is not empty after patch, as expected 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html.rej
Comment 9 EWS 2021-05-02 09:27:41 PDT
Tools/Scripts/svn-apply failed to apply attachment 427515 [details] to trunk. Please resolve the conflicts and upload a new patch.
Comment 10 Sam Weinig 2021-05-02 09:37:27 PDT
Part 1 landed in https://trac.webkit.org/changeset/276884/webkit.
Comment 11 Sam Weinig 2021-05-02 09:45:59 PDT
Part 2 landed in https://trac.webkit.org/changeset/276885/webkit.
Comment 13 Aakash Jain 2021-05-03 03:40:01 PDT
(In reply to Sam Weinig from comment #8) > (In reply to Sam Weinig from comment #7) > > Breaking this in two to see if that makes the bots any happier. > > Alas, they are not. It seems there is something in the patch file that is > making them unhappy. Can you please file a bug about this (for our tooling)?