Summary: | Consider removing imported/w3c/canvas and canvas/philip | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||
Component: | Canvas | Assignee: | Sam Weinig <sam> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | aakash_jain, darin, dino, sabouhallawa, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | Other | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=215135 https://bugs.webkit.org/show_bug.cgi?id=193042 |
||||||||
Attachments: |
|
Description
Sam Weinig
2021-05-01 08:31:42 PDT
Simon/Dean, do either of you have opinions on this? I would like to come up with a way to figure out which tests are actually identical, but the changes in test runners between the 3 copies makes this harder than one would like. I support their removal. Created attachment 427507 [details]
Patch
3.2 mb may be to big for the bots. Created attachment 427515 [details]
Part 1 (just canvas/philip)
Breaking this in two to see if that makes the bots any happier. (In reply to Sam Weinig from comment #7) > Breaking this in two to see if that makes the bots any happier. Alas, they are not. It seems there is something in the patch file that is making them unhappy. patching file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html Hunk #1 FAILED at 1. File LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html is not empty after patch, as expected 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/canvas/philip/tests/size.attributes.parse.whitespace.html.rej Tools/Scripts/svn-apply failed to apply attachment 427515 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Part 1 landed in https://trac.webkit.org/changeset/276884/webkit. Part 2 landed in https://trac.webkit.org/changeset/276885/webkit. (In reply to Sam Weinig from comment #8) > (In reply to Sam Weinig from comment #7) > > Breaking this in two to see if that makes the bots any happier. > > Alas, they are not. It seems there is something in the patch file that is > making them unhappy. Can you please file a bug about this (for our tooling)? |