Bug 225250

Summary: Defend further against a PlatformCALayer's owner becoming null in PlatformCALayerCocoa::drawLayerContents.
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Cameron McCormack (:heycam)
Reported 2021-04-30 14:07:26 PDT
At the end of PlatformCALayer::drawLayerContents, we null check layerContents for the platformCALayerShowRepaintCounter call but not the platformCALayerIncrementRepaintCount call.
Attachments
Patch (2.35 KB, patch)
2021-04-30 14:50 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (2.39 KB, patch)
2021-04-30 14:50 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-04-30 14:16:21 PDT
<rdar://37608882>
Cameron McCormack (:heycam)
Comment 2 2021-04-30 14:50:02 PDT
Created attachment 427450 [details] Patch
Cameron McCormack (:heycam)
Comment 3 2021-04-30 14:50:26 PDT
Created attachment 427452 [details] Patch
EWS
Comment 4 2021-04-30 18:19:27 PDT
Committed r276867 (237213@main): <https://commits.webkit.org/237213@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427452 [details].
Note You need to log in before you can comment on or make changes to this bug.