Bug 225249

Summary: Make the JIT pool smaller on AS
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch saam: review+

Filip Pizlo
Reported 2021-04-30 14:07:10 PDT
It improves perf a bit.
Attachments
the patch (6.12 KB, patch)
2021-04-30 14:08 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2021-04-30 14:08:46 PDT
Created attachment 427445 [details] the patch
Saam Barati
Comment 2 2021-04-30 14:23:27 PDT
Comment on attachment 427445 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=427445&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:336 > + if (Options::executablePoolSizeOverride()) > + reservation.size = Options::executablePoolSizeOverride(); this already exists right below. Just remove the ENABLE
Saam Barati
Comment 3 2021-04-30 14:25:39 PDT
Comment on attachment 427445 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=427445&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.cpp:409 > + , m_numAllocators(numberOfRegions) maybe we should rename numberOfRegions to maxNumberOfRegions
Filip Pizlo
Comment 4 2021-04-30 14:29:41 PDT
*** Bug 209037 has been marked as a duplicate of this bug. ***
Filip Pizlo
Comment 5 2021-04-30 14:52:13 PDT
Landed in https://trac.webkit.org/changeset/276855/webkit
Radar WebKit Bug Importer
Comment 6 2021-04-30 14:53:31 PDT
<rdar://problem/77400108>
Note You need to log in before you can comment on or make changes to this bug.