Summary: | [GPUP] Poll videoPlaybackQualityMetrics at the frequency is it accessed by script | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Carlson <eric.carlson> | ||||||
Component: | Media | Assignee: | Eric Carlson <eric.carlson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, glenn, jer.noble, philipj, sergio, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=225329 | ||||||||
Attachments: |
|
Description
Eric Carlson
2021-04-30 13:42:11 PDT
Created attachment 427448 [details]
Patch
Comment on attachment 427448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427448&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:997 > + static const double metricsAdvanceUpdate = 0.25; Can we make this Seconds? Created attachment 427457 [details]
Patch
Committed r276863 (237211@main): <https://commits.webkit.org/237211@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427457 [details]. Comment on attachment 427457 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427457&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:1186 > + auto now = WallTime::now(); Is WallTime the right thing to use here, instead of MonotonicTime? (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 427457 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=427457&action=review > > > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:1186 > > + auto now = WallTime::now(); > > Is WallTime the right thing to use here, instead of MonotonicTime? Good point, thanks. I'll fix that in https://bugs.webkit.org/show_bug.cgi?id=225329. |