Bug 225244

Summary:

[iOS] Make AccessibilityReduceMotion test case work on iOS

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit Misc.

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, pvollan, simon.fraser, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=222381

Bug Depends on:

225542

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch for landing	ews-feeder: commit-queue-
Patch for landing	ews-feeder: commit-queue-
Patch for landing	none
Patch for landing	none
Patch for landing	none

Brent Fulgham

Reported 2021-04-30 13:39:12 PDT

New tests for Accessibility-related features were added in Bug 215664, but only for macOS. We support these same features on iOS, and should have test coverage. This patch gets equivalent testing running on iOS.

Attachments
Patch (7.49 KB, patch) 2021-05-05 20:29 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (7.58 KB, patch) 2021-05-06 13:28 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch (8.56 KB, patch) 2021-05-06 18:05 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch for landing (8.44 KB, patch) 2021-05-07 12:11 PDT, Brent Fulgham	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (8.43 KB, patch) 2021-05-07 12:37 PDT, Brent Fulgham	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing (8.40 KB, patch) 2021-05-07 12:56 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch for landing (7.41 KB, patch) 2021-05-07 15:33 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch for landing (7.41 KB, patch) 2021-05-07 15:37 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-05-05 20:27:37 PDT

<rdar://problem/77589455>

Brent Fulgham

Comment 2 2021-05-05 20:29:58 PDT

Created attachment 427846 [details] Patch

Brent Fulgham

Comment 3 2021-05-06 13:28:27 PDT

Created attachment 427929 [details] Patch

Per Arne Vollan

Comment 4 2021-05-06 14:39:17 PDT

Comment on attachment 427929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427929&action=review R=me. > Tools/TestWebKitAPI/Tests/WebKit/AccessibilityReduceMotion.mm:46 > +SOFT_LINK_CONSTANT_FOR_SOURCE(PAL, libAccessibility, kAXSReduceMotionPreference, CFStringRef) Should PAL be used here?

Brent Fulgham

Comment 5 2021-05-06 18:05:47 PDT

Created attachment 427969 [details] Patch

Per Arne Vollan

Comment 6 2021-05-07 12:03:54 PDT

Comment on attachment 427969 [details] Patch R=me.

Brent Fulgham

Comment 7 2021-05-07 12:11:33 PDT

Created attachment 428020 [details] Patch for landing

Brent Fulgham

Comment 8 2021-05-07 12:37:51 PDT

Created attachment 428023 [details] Patch for landing

Brent Fulgham

Comment 9 2021-05-07 12:56:41 PDT

Created attachment 428026 [details] Patch for landing

EWS

Comment 10 2021-05-07 14:42:37 PDT

Committed r277201 (237473@main): <https://commits.webkit.org/237473@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428026 [details].

Simon Fraser (smfr)

Comment 11 2021-05-07 14:55:43 PDT

Comment on attachment 428026 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=428026&action=review > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58 > + <CommandLineArguments> > + <CommandLineArgument > + argument = "--gtest_filter=WebKit.AccessibilityReduceMotion" > + isEnabled = "YES"> > + </CommandLineArgument> > + </CommandLineArguments> Did you mean to commit this?

Simon Fraser (smfr)

Comment 12 2021-05-07 14:56:24 PDT

Comment on attachment 428026 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=428026&action=review > Source/WebKit/ChangeLog:10 > + Reviewed by Per Arne Vollan. This gives above the paragraph above.

Brent Fulgham

Comment 13 2021-05-07 15:20:33 PDT

(In reply to Simon Fraser (smfr) from comment #11) > Comment on attachment 428026 [details] > Patch for landing > > View in context: > https://bugs.webkit.org/attachment.cgi?id=428026&action=review > > > Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:58 > > + <CommandLineArguments> > > + <CommandLineArgument > > + argument = "--gtest_filter=WebKit.AccessibilityReduceMotion" > > + isEnabled = "YES"> > > + </CommandLineArgument> > > + </CommandLineArguments> > > Did you mean to commit this? :-(

WebKit Commit Bot

Comment 14 2021-05-07 15:22:10 PDT

Re-opened since this is blocked by bug 225542

Brent Fulgham

Comment 15 2021-05-07 15:33:27 PDT

Created attachment 428043 [details] Patch for landing

Brent Fulgham

Comment 16 2021-05-07 15:37:01 PDT

Created attachment 428047 [details] Patch for landing

EWS

Comment 17 2021-05-07 16:03:51 PDT

Committed r277209 (237481@main): <https://commits.webkit.org/237481@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 428047 [details].

Note You need to log in before you can comment on or make changes to this bug.