Bug 225241

Summary: [webkitcmpy] Better document inner-workings of identifier generation
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dean_johnson, dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2021-04-30 12:06:01 PDT
Dean Johnson recommended adding more comments to the implementation details of webkitscmpy.
Attachments
Patch (5.97 KB, patch)
2021-04-30 12:13 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (16.21 KB, patch)
2021-04-30 14:28 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jonathan Bedard
Comment 1 2021-04-30 12:13:23 PDT
Created attachment 427440 [details] Patch
Jonathan Bedard
Comment 2 2021-04-30 14:28:34 PDT
Created attachment 427447 [details] Patch
Dean Johnson
Comment 3 2021-04-30 14:39:28 PDT
Comment on attachment 427447 [details] Patch Unofficial r+; LGTM.
dewei_zhu
Comment 4 2021-04-30 14:40:05 PDT
Comment on attachment 427447 [details] Patch r=me
EWS
Comment 5 2021-04-30 15:24:22 PDT
Committed r276856 (237207@main): <https://commits.webkit.org/237207@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427447 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-30 15:25:17 PDT
<rdar://problem/77401337>
Note You need to log in before you can comment on or make changes to this bug.