Bug 225241

Summary: [webkitcmpy] Better document inner-workings of identifier generation
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: aakash_jain, dean_johnson, dewei_zhu, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Jonathan Bedard 2021-04-30 12:06:01 PDT
Dean Johnson recommended adding more comments to the implementation details of webkitscmpy.
Comment 1 Jonathan Bedard 2021-04-30 12:13:23 PDT
Created attachment 427440 [details]
Patch
Comment 2 Jonathan Bedard 2021-04-30 14:28:34 PDT
Created attachment 427447 [details]
Patch
Comment 3 Dean Johnson 2021-04-30 14:39:28 PDT
Comment on attachment 427447 [details]
Patch

Unofficial r+; LGTM.
Comment 4 dewei_zhu 2021-04-30 14:40:05 PDT
Comment on attachment 427447 [details]
Patch

r=me
Comment 5 EWS 2021-04-30 15:24:22 PDT
Committed r276856 (237207@main): <https://commits.webkit.org/237207@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427447 [details].
Comment 6 Radar WebKit Bug Importer 2021-04-30 15:25:17 PDT
<rdar://problem/77401337>