Summary: | REGRESSION: [ iOS ] 11 http/wpt/webauthn/ tests are crashing | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, jiewen_tan, webkit-bug-importer, youennf | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Jiewen Tan
2021-04-30 01:01:55 PDT
Created attachment 427400 [details]
Patch
Comment on attachment 427400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review > Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489 > + runPresenterInternal(transports); Instead of introducing another virtual method, can we use something like: if (isMock()) return; Comment on attachment 427400 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427400&action=review >> Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp:489 >> + runPresenterInternal(transports); > > Instead of introducing another virtual method, can we use something like: > if (isMock()) > return; The design of the testing infrastructure here is to make the authenticator manager unaware of whether or not it's mocking. That's why we have all kinds of different virtual methods. Comment on attachment 427400 [details]
Patch
r=me
Comment on attachment 427400 [details]
Patch
Thanks Brent for r+ this patch.
Committed r276972 (237301@main): <https://commits.webkit.org/237301@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427400 [details]. |