Bug 225224

Summary: Avoid some null pointer dereferences in PlatformCALayer::drawLayerContents.
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, thorton, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Cameron McCormack (:heycam)
Reported 2021-04-29 21:48:40 PDT
<rdar://76359027>
Attachments
Patch (3.85 KB, patch)
2021-04-29 21:57 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (2.35 KB, patch)
2021-04-30 14:52 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (2.41 KB, patch)
2021-04-30 14:56 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-04-29 21:57:55 PDT
Created attachment 427398 [details] Patch
Cameron McCormack (:heycam)
Comment 2 2021-04-29 22:09:36 PDT
Comment on attachment 427398 [details] Patch Will split this into two patches.
Cameron McCormack (:heycam)
Comment 3 2021-04-30 14:52:23 PDT
Created attachment 427453 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-04-30 14:53:39 PDT
Comment on attachment 427453 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427453&action=review > Source/WebCore/ChangeLog:13 > + setIsCALayerContext and setIsAcceleratedContext both assume (and assert) > + that the GraphicsContext has a platform context directly in m_data, > + but m_data is null when the GraphicsContext a display list recording > + context. These calls are unnecessary when not working with a > + CG-backed GraphicsContext, so just skip them in this case. This should probably mention DOM Rendering in GPUP
Cameron McCormack (:heycam)
Comment 5 2021-04-30 14:56:52 PDT
Created attachment 427454 [details] Patch
EWS
Comment 6 2021-04-30 17:43:14 PDT
Committed r276866 (237212@main): <https://commits.webkit.org/237212@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427454 [details].
Note You need to log in before you can comment on or make changes to this bug.