Summary: | Add proper WML error handling | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | XML | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 20393 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2008-11-26 18:46:45 PST
Created attachment 25549 [details]
Initial patch
Created attachment 25550 [details]
LayoutTest changes
Comment on attachment 25549 [details]
Initial patch
With minor comments:
1) our error messages should really be localized
2) should use something like " if (pageState && !pageState->...)"
(In reply to comment #3) > (From update of attachment 25549 [details] [review]) > With minor comments: > > 1) our error messages should really be localized The other XML tokenizer error messages are handled the same. If it's a problem, it's a general problem, would need to investigate how Mac handles translation. > 2) should use something like " if (pageState && !pageState->...)" Fixed. Landed in r38816. |