Bug 22522

Summary: Add proper WML error handling
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: XMLAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Macintosh   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 20393    
Attachments:
Description Flags
Initial patch
staikos: review+
LayoutTest changes staikos: review+

Description Nikolas Zimmermann 2008-11-26 18:46:45 PST
WML treats all errors as fatal errors. That means any error within a document needs to be presented as 'parsing' error by the tokenizer - just like to XML parsing errors.
Comment 1 Nikolas Zimmermann 2008-11-26 20:49:42 PST
Created attachment 25549 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2008-11-26 20:50:08 PST
Created attachment 25550 [details]
LayoutTest changes
Comment 3 George Staikos 2008-11-26 20:56:06 PST
Comment on attachment 25549 [details]
Initial patch

With minor comments: 

1) our error messages should really be localized
2) should use something like " if (pageState && !pageState->...)"
Comment 4 Nikolas Zimmermann 2008-11-26 21:09:06 PST
(In reply to comment #3)
> (From update of attachment 25549 [details] [review])
> With minor comments: 
> 
> 1) our error messages should really be localized
The other XML tokenizer error messages are handled the same. If it's a problem, it's a general problem, would need to investigate how Mac handles translation.

> 2) should use something like " if (pageState && !pageState->...)"
Fixed.

Landed in r38816.