| Summary: | _WKWebAuthenticationPanelDelegate registration and assertion SPI doesn't work without an LAContext | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jiewen Tan <jiewen_tan> | ||||
| Component: | WebKit Misc. | Assignee: | Jiewen Tan <jiewen_tan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, jiewen_tan, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Jiewen Tan
2021-04-29 16:47:08 PDT
Created attachment 427387 [details]
Patch
Comment on attachment 427387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review r=me > Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146 > + if (shouldUseAlternateAttributes() && !context) { Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good. Comment on attachment 427387 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427387&action=review Thanks Brent for r+ this patch. >> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:146 >> + if (shouldUseAlternateAttributes() && !context) { > > Looks like we should have noticed that this path didn't match the other verifyUser. :-( Looks good. Yup, look over that there are now two architectures in macOS. Committed r276851 (237202@main): <https://commits.webkit.org/237202@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427387 [details]. |