Bug 225210

Summary:

[macCatalyst] "Enter Full Screen" button in media controls disappears

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Media

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric.carlson, ews-watchlist, glenn, hi, jer.noble, philipj, sergio, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+
Patch	none

Description Devin Rousso 2021-04-29 14:40:35 PDT

Comment 1 Devin Rousso 2021-04-29 14:40:46 PDT

<rdar://problem/77010150>

Comment 2 Devin Rousso 2021-04-29 15:32:07 PDT

Created attachment 427378 [details]
Patch

Comment 3 Eric Carlson 2021-05-03 12:08:19 PDT

Comment on attachment 427378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427378&action=review

> Source/WebCore/ChangeLog:10
> +        must `webkitSupportsFullscreen`, which calls into `MediaPlayerPrivate::supportsFullscreen`.

?  s/must/must call/

Comment 4 Devin Rousso 2021-05-03 12:10:31 PDT

Comment on attachment 427378 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427378&action=review

>> Source/WebCore/ChangeLog:10
>> +        must `webkitSupportsFullscreen`, which calls into `MediaPlayerPrivate::supportsFullscreen`.
> 
> ?  s/must/must call/

Heh I was trying to use `webkitSupportsFullscreen` as a verb 😅

I'll rephrase it so it's more clear.

Comment 5 Devin Rousso 2021-05-03 12:15:36 PDT

Created attachment 427585 [details]
Patch

Comment 6 EWS 2021-05-03 12:58:53 PDT

Committed r276918 (237260@main): <https://commits.webkit.org/237260@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427585 [details].