Bug 225185

Summary: [Image-Set]: Support Resolution and Type as optional arguments
Product: WebKit Reporter: Oliver Williams <oliverwilliams345>
Component: CSSAssignee: Ryan Reno <rreno>
Status: RESOLVED FIXED    
Severity: Normal CC: dev, karlcow, ntim, rreno, sabouhallawa, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: BrowserCompat, InRadar, WPTImpact
Version: Safari 14   
Hardware: Unspecified   
OS: Unspecified   
URL: https://wpt.fyi/results/css/css-images/image-set/image-set-computed.sub.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&view=interop&q=label%3Ainterop-2023-webcompat
See Also: https://bugs.webkit.org/show_bug.cgi?id=251811

Description Oliver Williams 2021-04-29 02:13:55 PDT
Safari seems to not currently support the type option, which allows new image formats like webp to be used while specifying a fall-back image in a more well supported format like jpeg or png. 

background-image: image-set( "foo.avif" type("image/avif"), "foo.jpg" type("image/jpeg") );

The relevant part of spec is here: https://drafts.csswg.org/css-images-4/#image-set-notation
Comment 1 Radar WebKit Bug Importer 2021-05-06 02:14:13 PDT
<rdar://problem/77598590>
Comment 2 Karl Dubost 2023-01-25 23:34:17 PST
This is failing a couple of tests in 
http://wpt.live/css/css-images/image-set/image-set-computed.sub.html

and has impact on Interop 2023.
Comment 4 Ryan Reno 2023-02-23 15:20:27 PST
Resolution is also an optional parameter. As of right now we require resolution like the -webkit-image-set function did.
Comment 5 Ryan Reno 2023-02-23 15:21:15 PST
*** Bug 251197 has been marked as a duplicate of this bug. ***
Comment 6 Ryan Reno 2023-02-23 15:38:32 PST
Pull request: https://github.com/WebKit/WebKit/pull/10623
Comment 7 EWS 2023-02-24 09:20:48 PST
Committed 260796@main (e3554c53fff0): <https://commits.webkit.org/260796@main>

Reviewed commits have been landed. Closing PR #10623 and removing active labels.