Bug 225170

Summary: Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: New BugsAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, ews-watchlist, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jean-Yves Avenard [:jya]
Reported 2021-04-28 16:24:03 PDT
Adopt AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification
Attachments
Patch (9.72 KB, patch)
2021-04-28 17:33 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (9.82 KB, patch)
2021-04-29 18:33 PDT, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jean-Yves Avenard [:jya]
Comment 1 2021-04-28 17:11:23 PDT
rdar://77086915
Radar WebKit Bug Importer
Comment 2 2021-04-28 17:11:34 PDT
<rdar://problem/77293208>
Jean-Yves Avenard [:jya]
Comment 3 2021-04-28 17:19:35 PDT
rdar://problem/77086915
Jean-Yves Avenard [:jya]
Comment 4 2021-04-28 17:19:50 PDT
<rdar://problem/77086915>
Jean-Yves Avenard [:jya]
Comment 5 2021-04-28 17:33:27 PDT
Created attachment 427314 [details] Patch
Eric Carlson
Comment 6 2021-04-29 10:07:01 PDT
Comment on attachment 427314 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427314&action=review > Source/WebCore/ChangeLog:11 > + The current handling of AVSampleBufferAudioRendererWasFlushedAutomaticallyNotification is currently broken s/The current handling/The handling/ > Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:974 > + if (!trackId.isEmpty()) > + reenqueSamples(trackId); It might be worth logging an error if the track id isn't found.
Jean-Yves Avenard [:jya]
Comment 7 2021-04-29 18:33:30 PDT
Created attachment 427394 [details] Patch
EWS
Comment 8 2021-04-29 19:04:37 PDT
Committed r276828 (237183@main): <https://commits.webkit.org/237183@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427394 [details].
Note You need to log in before you can comment on or make changes to this bug.