Bug 225167

Summary:	Sampled Page Top Color: hook into painting logic instead of taking snapshots
Product:	WebKit	Reporter:	Devin Rousso <hi>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW
Severity:	Normal	CC:	bdakin, hi, thorton, webkit-bug-importer
Priority:	P2	Keywords:	InRadar
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=225942
Bug Depends on:	224987
Bug Blocks:

Devin Rousso

Reported 2021-04-28 15:50:10 PDT

Review feedback of Bug 224987 suggested that rather than using `snapshotFrameRect` (and `Document::hitTest` to check if that location is 3rd party) to get the color of pixels in the page, which can be expensive, we should hook into painting logic. Doing so will also (likely) make it easier to support non-sRGB color spaces, as right now `snapshotFrameRect` always uses sRGB.

Attachments
Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2021-04-28 18:00:07 PDT

<rdar://problem/77295389>

Tim Horton

Comment 2 2021-05-14 15:21:00 PDT

Compositing makes this ... hard.

Note You need to log in before you can comment on or make changes to this bug.