Bug 225157

Summary: Make sure webkitpy tests pass on Linux and on more Python versions
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Sam Sneddon [:gsnedders]
Reported 2021-04-28 11:15:33 PDT
We only actually run webkitpy tests in CI on macOS Big Sur, and we only run these with Python 2.7 + Python 3.8, and there's enough platform-specific code in webkitpy that it's unsurprising that some tests fail.
Attachments
Patch (16.75 KB, patch)
2021-04-28 11:29 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-04-28 11:29:10 PDT
Created attachment 427283 [details] Patch
Jonathan Bedard
Comment 2 2021-04-28 15:35:48 PDT
Comment on attachment 427283 [details] Patch Looks good, although I don't have a Linux machine to test on handy.
EWS
Comment 3 2021-04-29 02:45:27 PDT
Committed r276762 (237151@main): <https://commits.webkit.org/237151@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427283 [details].
Radar WebKit Bug Importer
Comment 4 2021-04-29 02:46:17 PDT
<rdar://problem/77311316>
Note You need to log in before you can comment on or make changes to this bug.