Bug 225149

Summary: Set audio transceiver nMax to 1
Product: WebKit Reporter: youenn fablet <youennf>
Component: WebRTCAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, rbuis, rniwa, sergio, tommyw, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description youenn fablet 2021-04-28 05:41:12 PDT
Set audio transceiver nMax to 1, we do not need more currently
Comment 1 youenn fablet 2021-04-28 05:48:42 PDT
<rdar://75956639>
Comment 2 youenn fablet 2021-04-28 05:52:27 PDT
Created attachment 427255 [details]
Patch
Comment 3 Alex Christensen 2021-04-28 08:02:55 PDT
Comment on attachment 427255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427255&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://75956639>

I don't understand how this is related or why it only applies to audio but not video.  Maybe a comment in the radar.

> LayoutTests/webrtc/audio-addTransceiver.html:21
> +    assert_true(sdp.indexOf('baz') === -1);

You should check that 'foo' is found at index 0.
I assume there is already a test for video encodings, but if not it would be good to add.
Comment 4 youenn fablet 2021-04-28 08:49:33 PDT
(In reply to Alex Christensen from comment #3)
> Comment on attachment 427255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427255&action=review
> 
> > Source/WebCore/ChangeLog:5
> > +        <rdar://75956639>
> 
> I don't understand how this is related or why it only applies to audio but
> not video.  Maybe a comment in the radar.

Simulcast is mostly a thing for video, where you might want to send several times the same video at different bitrate. For audio, simulcast is less needed and there are other ways to do it in a good enough way.

> > LayoutTests/webrtc/audio-addTransceiver.html:21
> > +    assert_true(sdp.indexOf('baz') === -1);
> 
> You should check that 'foo' is found at index 0.
> I assume there is already a test for video encodings, but if not it would be
> good to add.

We have tests in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpParameters-encodings.html.
Comment 5 EWS 2021-04-28 09:29:21 PDT
Committed r276717 (237121@main): <https://commits.webkit.org/237121@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427255 [details].