Bug 225149 – Set audio transceiver nMax to 1

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Set audio transceiver nMax to 1, we do not need more currently

[youenn fablet]

<rdar://75956639>

[youenn fablet]

Created attachment 427255 [details]
Patch

[Alex Christensen]

Comment on attachment 427255 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427255&action=review

> Source/WebCore/ChangeLog:5
> +        <rdar://75956639>

I don't understand how this is related or why it only applies to audio but not video.  Maybe a comment in the radar.

> LayoutTests/webrtc/audio-addTransceiver.html:21
> +    assert_true(sdp.indexOf('baz') === -1);

You should check that 'foo' is found at index 0.
I assume there is already a test for video encodings, but if not it would be good to add.

[youenn fablet]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 427255 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427255&action=review
> 
> > Source/WebCore/ChangeLog:5
> > +        <rdar://75956639>
> 
> I don't understand how this is related or why it only applies to audio but
> not video.  Maybe a comment in the radar.

Simulcast is mostly a thing for video, where you might want to send several times the same video at different bitrate. For audio, simulcast is less needed and there are other ways to do it in a good enough way.

> > LayoutTests/webrtc/audio-addTransceiver.html:21
> > +    assert_true(sdp.indexOf('baz') === -1);
> 
> You should check that 'foo' is found at index 0.
> I assume there is already a test for video encodings, but if not it would be
> good to add.

We have tests in LayoutTests/imported/w3c/web-platform-tests/webrtc/RTCRtpParameters-encodings.html.

[EWS]

Committed r276717 (237121@main): <https://commits.webkit.org/237121@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427255 [details].