Bug 225141

Summary: don't try to create custom scrollbars for fullscreen placeholders
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Layout and RenderingAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, fred.wang, glenn, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Cameron McCormack (:heycam)
Reported 2021-04-27 23:09:49 PDT
We can end up calling RenderScrollbar::createCustomScrollbar with `element = nullptr` from RenderLayerScrollableArea::createScrollbar, when the renderer is a RenderFullscreenPlaceholder.
Attachments
Patch (4.23 KB, patch)
2021-04-27 23:14 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Patch (4.33 KB, patch)
2021-04-28 15:30 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-04-27 23:12:57 PDT
<rdar://64800098>
Cameron McCormack (:heycam)
Comment 2 2021-04-27 23:14:46 PDT
Created attachment 427240 [details] Patch
Simon Fraser (smfr)
Comment 3 2021-04-28 09:17:44 PDT
Comment on attachment 427240 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427240&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=225141 Should be a radar link under this line. > LayoutTests/fullscreen/full-screen-crash-custom-scrollbars-expected.txt:1 > +END OF TEST We usually say "Passes if the test does not crash".
Cameron McCormack (:heycam)
Comment 4 2021-04-28 15:30:35 PDT
Created attachment 427300 [details] Patch
EWS
Comment 5 2021-04-28 16:01:05 PDT
Committed r276739 (237139@main): <https://commits.webkit.org/237139@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427300 [details].
Note You need to log in before you can comment on or make changes to this bug.