Bug 225141 - don't try to create custom scrollbars for fullscreen placeholders
Summary: don't try to create custom scrollbars for fullscreen placeholders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-27 23:09 PDT by Cameron McCormack (:heycam)
Modified: 2021-04-28 16:01 PDT (History)
12 users (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2021-04-27 23:14 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Patch (4.33 KB, patch)
2021-04-28 15:30 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-04-27 23:09:49 PDT 
We can end up calling RenderScrollbar::createCustomScrollbar with `element = nullptr` from RenderLayerScrollableArea::createScrollbar, when the renderer is a RenderFullscreenPlaceholder.
Comment 1 Cameron McCormack (:heycam) 2021-04-27 23:12:57 PDT 
<rdar://64800098>
Comment 2 Cameron McCormack (:heycam) 2021-04-27 23:14:46 PDT 
Created attachment 427240 [details]
Patch
Comment 3 Simon Fraser (smfr) 2021-04-28 09:17:44 PDT 
Comment on attachment 427240 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427240&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=225141

Should be a radar link under this line.

> LayoutTests/fullscreen/full-screen-crash-custom-scrollbars-expected.txt:1
> +END OF TEST

We usually say "Passes if the test does not crash".
Comment 4 Cameron McCormack (:heycam) 2021-04-28 15:30:35 PDT 
Created attachment 427300 [details]
Patch
Comment 5 EWS 2021-04-28 16:01:05 PDT 
Committed r276739 (237139@main): <https://commits.webkit.org/237139@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427300 [details].