Summary: | [JSC] Optimize bound function calls | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||
Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||||||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||||||||
Severity: | Normal | CC: | ews-watchlist, joepeck, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||||||||
Attachments: |
|
Description
Yusuke Suzuki
2021-04-27 20:47:12 PDT
Created attachment 427233 [details]
Patch
Created attachment 427489 [details]
Patch
Created attachment 427491 [details]
Patch
Created attachment 427492 [details]
Patch
Created attachment 427493 [details]
Patch
Created attachment 427494 [details]
Patch
Created attachment 427509 [details]
Patch
Created attachment 427517 [details]
Patch
Comment on attachment 427517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review > Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764 > + RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count); Did you mean "target" instead of "count"? > Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939 > + return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get()); Is the 2nd argument supposed to be "additionalCount"? This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js. Comment on attachment 427517 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427517&action=review >> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h:764 >> + RegisterID* emitCreateArgumentsButterflyExcludingThis(RegisterID* dst, RegisterID* count); > > Did you mean "target" instead of "count"? Changed to target. Yeah, "count" is the one from the old patch. >> Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:1939 >> + return generator.emitCreateArgumentsButterflyExcludingThis(generator.finalDestination(dst), additionalCount.get()); > > Is the 2nd argument supposed to be "additionalCount"? This doesn't match the `@createArgumentsButterfly(this);` in FunctionPrototype.js. Changed to target. Created attachment 428162 [details]
Patch
Created attachment 428163 [details]
Patch
Pull request: https://github.com/WebKit/WebKit/pull/10116 Committed 260303@main (d99a52c87599): <https://commits.webkit.org/260303@main> Reviewed commits have been landed. Closing PR #10116 and removing active labels. |