Bug 225126
| Summary: | [Stress Tests EWS] WPT tests failing in `run-layout-tests-in-guard-malloc-stress-mode` | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryan Haddad <ryanhaddad> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | aakash_jain, ap, gsnedders, jbedard, rego, rniwa, webkit-bot-watchers-bugzilla, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | WebKit Nightly Build | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=224358 | ||
Ryan Haddad
It appears that whenever stress tests EWS runs the `run-layout-tests-in-guard-malloc-stress-mode ` step for tests in the imported/w3c/web-platform-tests directory, the wptwk server isn't started, which causes the tests to fail
Example build showing a WPT test passing in the `run-layout-tests-in-stress-mode` step, but failing in in the `run-layout-tests-in-guard-malloc-stress-mode` step:
https://ews-build.webkit.org/#/builders/62/builds/1853
Test result showing the test failing with a render tree dump for about:blank:
https://ews-build.s3-us-west-2.amazonaws.com/macOS-Release-WK2-Stress-Tests-EWS/r427118-1853-guard-malloc/results.html
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Radar WebKit Bug Importer
<rdar://problem/77236114>
Ryan Haddad
The `run-layout-tests-in-stress-mode` test run is indeed starting wptwk, as seen in the logs (and the fact that the test passes in that mode)
https://ews-build.webkit.org/#/builders/62/builds/1853/steps/14/logs/stdio
The only difference for the `run-layout-tests-in-guard-malloc-stress-mode ` step is the addition of `--guard-malloc`, so maybe something is broken in `run-webkit-tests` itself?
Jonathan Bedard
(In reply to Ryan Haddad from comment #2)
> The `run-layout-tests-in-stress-mode` test run is indeed starting wptwk, as
> seen in the logs (and the fact that the test passes in that mode)
> https://ews-build.webkit.org/#/builders/62/builds/1853/steps/14/logs/stdio
>
> The only difference for the `run-layout-tests-in-guard-malloc-stress-mode `
> step is the addition of `--guard-malloc`, so maybe something is broken in
> `run-webkit-tests` itself?
Very strongly suspect that is the case. It's also probably a very easy fix. I'll take a look tomorrow.
Ryosuke Niwa
I've seen regular layout test step reproducing the same issue too.
Jonathan Bedard
This seems to be about guard-malloc specifically, not a general problem with all invocations of run-webkit-tests.
Jonathan Bedard
We are starting the WPT server in guard-malloc mode, seems like the web-platforms tests may be genuinely timing out.