Bug 225115

Summary: Optimise Port._expected_baselines_for_suffixes
Product: WebKit Reporter: Sam Sneddon [:gsnedders] <gsnedders>
Component: Tools / TestsAssignee: Sam Sneddon [:gsnedders] <gsnedders>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, glenn, jbedard, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=224989
Attachments:
Description Flags
Patch none

Description Sam Sneddon [:gsnedders] 2021-04-27 11:23:19 PDT
This function is hot in the Port.reference_files case on platforms like Big Sur with WebKit2, as we're calling it with a long baseline search path and with many suffixes. A lot of the cost is in the repeated calls of os.path.join which notably only differ by the suffix.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-27 11:26:24 PDT
Created attachment 427176 [details]
Patch
Comment 2 EWS 2021-04-27 15:06:41 PDT
Committed r276669 (237088@main): <https://commits.webkit.org/237088@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427176 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-27 15:07:24 PDT
<rdar://problem/77232724>