RESOLVED FIXED225115
Optimise Port._expected_baselines_for_suffixes 
https://bugs.webkit.org/show_bug.cgi?id=225115
Summary Optimise Port._expected_baselines_for_suffixes
Sam Sneddon [:gsnedders]
Reported 2021-04-27 11:23:19 PDT
This function is hot in the Port.reference_files case on platforms like Big Sur with WebKit2, as we're calling it with a long baseline search path and with many suffixes. A lot of the cost is in the repeated calls of os.path.join which notably only differ by the suffix.
Attachments
Patch (2.50 KB, patch)
2021-04-27 11:26 PDT, Sam Sneddon [:gsnedders] 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1 2021-04-27 11:26:24 PDT
Created attachment 427176 [details] Patch
EWS
Comment 2 2021-04-27 15:06:41 PDT
Committed r276669 (237088@main): <https://commits.webkit.org/237088@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427176 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-27 15:07:24 PDT
<rdar://problem/77232724>
Note You need to log in before you can comment on or make changes to this bug.