Bug 225115 - Optimise Port._expected_baselines_for_suffixes
Summary: Optimise Port._expected_baselines_for_suffixes
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Sneddon [:gsnedders]
Keywords: InRadar
Depends on:
Reported: 2021-04-27 11:23 PDT by Sam Sneddon [:gsnedders]
Modified: 2021-04-27 15:07 PDT (History)
4 users (show)

See Also:

Patch (2.50 KB, patch)
2021-04-27 11:26 PDT, Sam Sneddon [:gsnedders]
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2021-04-27 11:23:19 PDT
This function is hot in the Port.reference_files case on platforms like Big Sur with WebKit2, as we're calling it with a long baseline search path and with many suffixes. A lot of the cost is in the repeated calls of os.path.join which notably only differ by the suffix.
Comment 1 Sam Sneddon [:gsnedders] 2021-04-27 11:26:24 PDT
Created attachment 427176 [details]
Comment 2 EWS 2021-04-27 15:06:41 PDT
Committed r276669 (237088@main): <https://commits.webkit.org/237088@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427176 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-27 15:07:24 PDT