| Summary: | StructureStubInfo and PolymorphicAccess should account for their non-GC memory | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Keith Miller <keith_miller> | ||||||||
| Component: | New Bugs | Assignee: | Keith Miller <keith_miller> | ||||||||
| Status: | REOPENED --- | ||||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 225930 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Keith Miller
2021-04-27 11:05:18 PDT
Created attachment 427172 [details]
Patch
Created attachment 427175 [details]
Patch
Comment on attachment 427175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review r=me > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389 > + size += sizeof(WatchpointsOnStructureStubInfo); m_watchpoints has a Bag of stuff. Do we need to add that size? Comment on attachment 427175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review >> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389 >> + size += sizeof(WatchpointsOnStructureStubInfo); > > m_watchpoints has a Bag of stuff. Do we need to add that size? Yeah, for some reason I thought the watchpoints were owned by the code block but that doesn't make sense since they are not references or pointers in the Bag. Created attachment 427179 [details]
Patch for landing
Committed r276655 (237082@main): <https://commits.webkit.org/237082@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427179 [details]. Re-opened since this is blocked by bug 225930 |