Bug 225113

Summary: StructureStubInfo and PolymorphicAccess should account for their non-GC memory
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: REOPENED    
Severity: Normal CC: commit-queue, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 225930    
Bug Blocks:    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch for landing none

Keith Miller
Reported 2021-04-27 11:05:18 PDT
StructureStubInfo and PolyMorphicAccess should account for their non-GC memory
Attachments
Patch (5.61 KB, patch)
2021-04-27 11:10 PDT, Keith Miller 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (5.61 KB, patch)
2021-04-27 11:20 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.41 KB, patch)
2021-04-27 12:04 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2021-04-27 11:10:27 PDT
Created attachment 427172 [details] Patch
Keith Miller
Comment 2 2021-04-27 11:20:48 PDT
Created attachment 427175 [details] Patch
Mark Lam
Comment 3 2021-04-27 11:46:41 PDT
Comment on attachment 427175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review r=me > Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389 > + size += sizeof(WatchpointsOnStructureStubInfo); m_watchpoints has a Bag of stuff. Do we need to add that size?
Keith Miller
Comment 4 2021-04-27 11:55:20 PDT
Comment on attachment 427175 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427175&action=review >> Source/JavaScriptCore/bytecode/PolymorphicAccess.cpp:389 >> + size += sizeof(WatchpointsOnStructureStubInfo); > > m_watchpoints has a Bag of stuff. Do we need to add that size? Yeah, for some reason I thought the watchpoints were owned by the code block but that doesn't make sense since they are not references or pointers in the Bag.
Keith Miller
Comment 5 2021-04-27 12:04:46 PDT
Created attachment 427179 [details] Patch for landing
EWS
Comment 6 2021-04-27 12:49:52 PDT
Committed r276655 (237082@main): <https://commits.webkit.org/237082@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427179 [details].
Radar WebKit Bug Importer
Comment 7 2021-04-27 12:50:20 PDT
<rdar://problem/77224968>
WebKit Commit Bot
Comment 8 2021-05-18 12:44:27 PDT
Re-opened since this is blocked by bug 225930
Note You need to log in before you can comment on or make changes to this bug.