Bug 225068

Summary: CodeBlock should do a better job accounting for extra memory it allocates.
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, ews-watchlist, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch for landing
ews-feeder: commit-queue-
Patch for landing
none
Patch for landing none

Description Keith Miller 2021-04-26 12:15:10 PDT
CodeBlock should do a better job accounting for extra memory it allocates.
Comment 1 Keith Miller 2021-04-26 12:21:04 PDT
Created attachment 427077 [details]
Patch
Comment 2 Mark Lam 2021-04-26 12:25:22 PDT
Comment on attachment 427077 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427077&action=review

r=me.  Looks like you have EWS issue.  Please fix.

> Source/WTF/ChangeLog:8
> +        Small convienience function to help compute the memory used by a Bag for JS CG

/convienience/convenience/
Comment 3 Keith Miller 2021-04-26 12:27:50 PDT
Created attachment 427079 [details]
Patch for landing
Comment 4 Keith Miller 2021-04-26 12:28:35 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 427077 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=427077&action=review
> 
> r=me.  Looks like you have EWS issue.  Please fix.

Will do! thanks!
Comment 5 Keith Miller 2021-04-26 12:35:37 PDT
Created attachment 427080 [details]
Patch for landing
Comment 6 Keith Miller 2021-04-26 12:36:39 PDT
Created attachment 427081 [details]
Patch for landing
Comment 7 EWS 2021-04-26 13:22:44 PDT
Committed r276610 (237039@main): <https://commits.webkit.org/237039@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427081 [details].
Comment 8 Radar WebKit Bug Importer 2021-04-26 13:23:18 PDT
<rdar://problem/77172976>