| Summary: | [iOS] Coalesce adjacent selection geometries when rendering individual selection quads | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Component: | Platform | Assignee: | Wenson Hsieh <wenson_hsieh> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bdakin, cdumez, changseok, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, hi, kondapallykalyan, megan_gardner, pdr, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Wenson Hsieh
2021-04-26 09:03:48 PDT
Created attachment 427152 [details]
For EWS
Created attachment 427153 [details]
For EWS
Comment on attachment 427153 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=427153&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1349 > +static Optional<SimpleRange> canonicalizeForImageOverlay(const SimpleRange& range) Can this be more specific than "canonicalize" which pretty much means nothing? Comment on attachment 427153 [details] For EWS View in context: https://bugs.webkit.org/attachment.cgi?id=427153&action=review >> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:1349 >> +static Optional<SimpleRange> canonicalizeForImageOverlay(const SimpleRange& range) > > Can this be more specific than "canonicalize" which pretty much means nothing? Good point. How about "expandForImageOverlay"? Created attachment 427293 [details]
Renaming
Committed r276746 (237146@main): <https://commits.webkit.org/237146@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427293 [details]. |