Bug 225052

Summary:

[CMake] Modernize WebKit GLib testing

Product:

WebKit

Reporter:

Don Olmstead <don.olmstead>

Component:

CMake

Assignee:

Don Olmstead <don.olmstead>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

annulen, aperez, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ews-feeder: commit-queue-
Patch	none
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	ews-feeder: commit-queue-
Patch	none

Don Olmstead

Reported 2021-04-26 07:54:05 PDT

Use targets

Attachments
Patch (6.34 KB, patch) 2021-04-26 07:57 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (6.61 KB, patch) 2021-04-26 08:20 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Patch (6.63 KB, patch) 2021-04-26 08:21 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (6.63 KB, patch) 2021-04-26 08:36 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (6.66 KB, patch) 2021-04-26 08:58 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (6.69 KB, patch) 2021-04-26 09:08 PDT, Don Olmstead	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (6.73 KB, patch) 2021-04-26 09:13 PDT, Don Olmstead	no flags	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Don Olmstead

Comment 1 2021-04-26 07:57:45 PDT Comment hidden (obsolete)

Created attachment 427046 [details] Patch

Don Olmstead

Comment 2 2021-04-26 08:20:09 PDT Comment hidden (obsolete)

Created attachment 427048 [details] Patch

Don Olmstead

Comment 3 2021-04-26 08:21:05 PDT Comment hidden (obsolete)

Created attachment 427049 [details] Patch

Don Olmstead

Comment 4 2021-04-26 08:36:21 PDT Comment hidden (obsolete)

Created attachment 427051 [details] Patch

Don Olmstead

Comment 5 2021-04-26 08:58:37 PDT Comment hidden (obsolete)

Created attachment 427053 [details] Patch

Don Olmstead

Comment 6 2021-04-26 09:08:51 PDT Comment hidden (obsolete)

Created attachment 427055 [details] Patch

Don Olmstead

Comment 7 2021-04-26 09:13:49 PDT

Created attachment 427056 [details] Patch

Adrian Perez

Comment 8 2021-04-26 10:16:51 PDT

Comment on attachment 427056 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427056&action=review > Tools/ChangeLog:8 > + Set values on targets directly rather than the older add_definitions and \o/

EWS

Comment 9 2021-04-26 10:33:03 PDT

Committed r276597 (237032@main): <https://commits.webkit.org/237032@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427056 [details].

Note You need to log in before you can comment on or make changes to this bug.