Bug 225052

Summary: [CMake] Modernize WebKit GLib testing
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: CMakeAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, aperez, ews-watchlist, gyuyoung.kim, mcatanzaro, ryuan.choi, sergio
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch
ews-feeder: commit-queue-
Patch none

Description Don Olmstead 2021-04-26 07:54:05 PDT 
Use targets
Comment 1 Don Olmstead 2021-04-26 07:57:45 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-04-26 08:20:09 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-04-26 08:21:05 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-04-26 08:36:21 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2021-04-26 08:58:37 PDT Comment hidden (obsolete)
Comment 6 Don Olmstead 2021-04-26 09:08:51 PDT Comment hidden (obsolete)
Comment 7 Don Olmstead 2021-04-26 09:13:49 PDT 
Created attachment 427056 [details]
Patch
Comment 8 Adrian Perez 2021-04-26 10:16:51 PDT 
Comment on attachment 427056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427056&action=review

> Tools/ChangeLog:8
> +        Set values on targets directly rather than the older add_definitions and

\o/
Comment 9 EWS 2021-04-26 10:33:03 PDT 
Committed r276597 (237032@main): <https://commits.webkit.org/237032@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427056 [details].