Bug 225052 - [CMake] Modernize WebKit GLib testing
Summary: [CMake] Modernize WebKit GLib testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-26 07:54 PDT by Don Olmstead
Modified: 2021-04-26 10:33 PDT (History)
7 users (show)

See Also:


Attachments
Patch (6.34 KB, patch)
2021-04-26 07:57 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.61 KB, patch)
2021-04-26 08:20 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2021-04-26 08:21 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.63 KB, patch)
2021-04-26 08:36 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.66 KB, patch)
2021-04-26 08:58 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.69 KB, patch)
2021-04-26 09:08 PDT, Don Olmstead
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (6.73 KB, patch)
2021-04-26 09:13 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2021-04-26 07:54:05 PDT
Use targets
Comment 1 Don Olmstead 2021-04-26 07:57:45 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2021-04-26 08:20:09 PDT Comment hidden (obsolete)
Comment 3 Don Olmstead 2021-04-26 08:21:05 PDT Comment hidden (obsolete)
Comment 4 Don Olmstead 2021-04-26 08:36:21 PDT Comment hidden (obsolete)
Comment 5 Don Olmstead 2021-04-26 08:58:37 PDT Comment hidden (obsolete)
Comment 6 Don Olmstead 2021-04-26 09:08:51 PDT Comment hidden (obsolete)
Comment 7 Don Olmstead 2021-04-26 09:13:49 PDT
Created attachment 427056 [details]
Patch
Comment 8 Adrian Perez 2021-04-26 10:16:51 PDT
Comment on attachment 427056 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=427056&action=review

> Tools/ChangeLog:8
> +        Set values on targets directly rather than the older add_definitions and

\o/
Comment 9 EWS 2021-04-26 10:33:03 PDT
Committed r276597 (237032@main): <https://commits.webkit.org/237032@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427056 [details].