Bug 225048

Summary: Refcount Style::Resolver
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, kangil.han, macpherson, menard, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
rniwa: review+
patch none

Antti Koivisto
Reported 2021-04-26 02:54:07 PDT
For safety, and to allow more sharing in the future.
Attachments
patch (11.72 KB, patch)
2021-04-26 02:55 PDT, Antti Koivisto 		rniwa: review+
DetailsFormatted DiffDiff
patch (12.18 KB, patch)
2021-04-26 04:23 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-04-26 02:55:51 PDT
Created attachment 427032 [details] patch
Ryosuke Niwa
Comment 2 2021-04-26 03:02:05 PDT
Comment on attachment 427032 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=427032&action=review > Source/WebCore/style/StyleResolver.h:83 > +class Resolver : public RefCounted<Resolver> { > public: Should we iso-heap this? > Source/WebCore/style/StyleScope.h:180 > HashSet<const Element*> m_elementsInHeadWithPendingSheets; > HashSet<const Element*> m_elementsInBodyWithPendingSheets; Yikes. We should use WeakHashSet for these! > Source/WebCore/style/StyleTreeResolver.h:73 > Scope* enclosingScope { nullptr }; Should this be RefPtr<Scope> as well?
Antti Koivisto
Comment 3 2021-04-26 04:23:58 PDT
Created attachment 427035 [details] patch
EWS
Comment 4 2021-04-26 06:18:02 PDT
Committed r276588 (237024@main): <https://commits.webkit.org/237024@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427035 [details].
Radar WebKit Bug Importer
Comment 5 2021-04-26 06:19:16 PDT
<rdar://problem/77150042>
Note You need to log in before you can comment on or make changes to this bug.