Bug 225045

Summary: [ews] Add new builder WPE-Build-Non-Unified-EWS
Product: WebKit Reporter: Diego Pino <dpino>
Component: WPE WebKitAssignee: Diego Pino <dpino>
Status: NEW    
Severity: Normal CC: aakash_jain, aperez, ap, bfulgham, bugs-noreply, ews-watchlist, jbedard, keith_miller, pgriffis, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=225385
https://bugs.webkit.org/show_bug.cgi?id=226088
https://bugs.webkit.org/show_bug.cgi?id=25385
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch dpino: review?

Diego Pino
Reported 2021-04-25 23:09:21 PDT
[ews] Add new builder WPE-Build-Non-Unified-EWS
Attachments
Patch (3.92 KB, patch)
2021-04-25 23:16 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (4.49 KB, patch)
2021-04-26 06:20 PDT, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (4.04 KB, patch)
2022-01-23 19:27 PST, Diego Pino 		no flags
DetailsFormatted DiffDiff
Patch (5.30 KB, patch)
2022-01-23 23:31 PST, Diego Pino 		dpino: review?
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2021-04-25 23:16:11 PDT
Created attachment 427024 [details] Patch
Aakash Jain
Comment 2 2021-04-26 05:22:04 PDT
Comment on attachment 427024 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=427024&action=review > Tools/ChangeLog:8 > + This new builder will build WPE with Unified builds disabled. That Where is the unified build disabled in this patch? If that setting is done on the bots, it would be better if the setting could be made in the configuration here, so that we don't end up in a situation where a newly configured bot misses that setting, and keep doing unified builds without anyone noticing. > Tools/CISupport/ews-app/ews/views/statusbubble.py:46 > + ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'mac-AS-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wpe-noun', 'wincairo', 'win', noun seems weird. maybe 'wpe-non-unified' might be better. > Tools/CISupport/ews-build/config.json:606 > + "name": "WPE-Build-Non-Unified-EWS", Would be better to name: "WPE-Non-Unified-Build-EWS"
Aakash Jain
Comment 3 2021-04-26 05:22:58 PDT
Also, please mention the motivation for this EWS.
Diego Pino
Comment 4 2021-04-26 06:20:08 PDT
Created attachment 427037 [details] Patch
Alexey Proskuryakov
Comment 5 2021-04-26 07:20:21 PDT
Comment on attachment 427037 [details] Patch I don’t think that we have any agreement to keep this configuration building. Please reach consensus on webkit-dev before imposing this new requirement on WebKit developers.
Diego Pino
Comment 6 2022-01-23 19:27:57 PST
Created attachment 449776 [details] Patch
Diego Pino
Comment 7 2022-01-23 23:31:56 PST
Created attachment 449785 [details] Patch
Note You need to log in before you can comment on or make changes to this bug.