Bug 225040

Summary: LayoutTests/http/tests/canvas/color-fonts/ tests have a typo
Product: WebKit Reporter: Cameron McCormack (:heycam) <heycam>
Component: Tools / TestsAssignee: Cameron McCormack (:heycam) <heycam>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, mmaxfield, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Cameron McCormack (:heycam)
Reported 2021-04-25 17:47:01 PDT
I don't think the typo has an effect on the tests' correctness though.
Attachments
Patch (24.47 KB, patch)
2021-04-25 17:50 PDT, Cameron McCormack (:heycam) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Cameron McCormack (:heycam)
Comment 1 2021-04-25 17:50:21 PDT
Created attachment 427016 [details] Patch
EWS
Comment 2 2021-04-28 00:07:10 PDT
Committed r276694 (237108@main): <https://commits.webkit.org/237108@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427016 [details].
Radar WebKit Bug Importer
Comment 3 2021-04-28 00:08:16 PDT
<rdar://problem/77251777>
Darin Adler
Comment 4 2021-04-28 15:07:27 PDT
This same mistake is in LayoutTests/fast/text/canvas-color-fonts. Maybe the right thing to do would be to delete those tests if they are now redundant. There are many tests that were imported into WPT where we still keep our originals around. Also found it in: fast/images/inline-image-box-with-no-alt-should-collapse-no-quirks.html fast/images/inline-image-box-with-no-alt-should-collapse-quirks.html imported/blink/fast/shapes/shape-outside-floats/shape-outside-floats-center-coord-positioning-crash.html I am thinking maybe a more sophisticated grep for this mistake is called for.
Note You need to log in before you can comment on or make changes to this bug.