Bug 225040 - LayoutTests/http/tests/canvas/color-fonts/ tests have a typo
Summary: LayoutTests/http/tests/canvas/color-fonts/ tests have a typo
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cameron McCormack (:heycam)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-04-25 17:47 PDT by Cameron McCormack (:heycam)
Modified: 2021-04-28 15:07 PDT (History)
4 users (show)

See Also:

Attachments
Patch (24.47 KB, patch)
2021-04-25 17:50 PDT, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cameron McCormack (:heycam) 2021-04-25 17:47:01 PDT 
I don't think the typo has an effect on the tests' correctness though.
Comment 1 Cameron McCormack (:heycam) 2021-04-25 17:50:21 PDT 
Created attachment 427016 [details]
Patch
Comment 2 EWS 2021-04-28 00:07:10 PDT 
Committed r276694 (237108@main): <https://commits.webkit.org/237108@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427016 [details].
Comment 3 Radar WebKit Bug Importer 2021-04-28 00:08:16 PDT 
<rdar://problem/77251777>
Comment 4 Darin Adler 2021-04-28 15:07:27 PDT 
This same mistake is in LayoutTests/fast/text/canvas-color-fonts. Maybe the right thing to do would be to delete those tests if they are now redundant. There are many tests that were imported into WPT where we still keep our originals around.

Also found it in:

    fast/images/inline-image-box-with-no-alt-should-collapse-no-quirks.html
    fast/images/inline-image-box-with-no-alt-should-collapse-quirks.html
    imported/blink/fast/shapes/shape-outside-floats/shape-outside-floats-center-coord-positioning-crash.html

I am thinking maybe a more sophisticated grep for this mistake is called for.