Bug 225031

Summary: [GPUP][iOS] Silent video playback can interrupt system audio
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric.carlson, ews-watchlist, glenn, jean-yves.avenard, peng.liu6, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, ews-feeder: commit-queue-
Patch for landing none

Description Jer Noble 2021-04-25 09:22:25 PDT
[GPUP][iOS] Silent video playback can interrupt system audio
Comment 1 Jer Noble 2021-04-25 09:23:00 PDT
<rdar://76652073>
Comment 2 Jer Noble 2021-04-25 09:30:35 PDT
Created attachment 427003 [details]
Patch
Comment 3 Jer Noble 2021-04-25 10:19:05 PDT
Created attachment 427004 [details]
Patch for landing
Comment 4 EWS 2021-04-25 13:32:32 PDT
Committed r276570 (237006@main): <https://commits.webkit.org/237006@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 427004 [details].
Comment 5 Darin Adler 2021-04-25 13:38:43 PDT
Comment on attachment 427004 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=427004&action=review

> Source/WebKit/GPUProcess/media/RemoteAudioSessionProxyManager.cpp:74
> +    AudioSession::CategoryType category = AudioSession::None;
> +    RouteSharingPolicy policy = RouteSharingPolicy::Default;

Next time we touch this, we can just use auto here to take advantage of the fact that the enumeration values already carry their type.