Bug 225028

Summary: Deploy Ref/RefPtr in DeleteSelectionCommand
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ews-watchlist, megan_gardner, mifenton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch for landing none

Ryosuke Niwa
Reported 2021-04-24 19:18:35 PDT
We should use more smart pointers in DeleteSelectionCommand.
Attachments
Patch (29.80 KB, patch)
2021-04-24 19:24 PDT, Ryosuke Niwa 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (29.99 KB, patch)
2021-04-24 19:34 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2021-04-24 19:24:32 PDT
Created attachment 426995 [details] Patch
Wenson Hsieh
Comment 2 2021-04-24 19:30:19 PDT
Comment on attachment 426995 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426995&action=review r=mews > Source/WebCore/editing/DeleteSelectionCommand.cpp:1044 > + Text& textNode = downcast<Text>(*endNode); Nit - auto& here.
Ryosuke Niwa
Comment 3 2021-04-24 19:34:54 PDT
Created attachment 426996 [details] Patch for landing
Ryosuke Niwa
Comment 4 2021-04-24 19:35:07 PDT
Comment on attachment 426996 [details] Patch for landing Wait for EWS.
Ryosuke Niwa
Comment 5 2021-04-24 23:00:03 PDT
Comment on attachment 426996 [details] Patch for landing Clearing flags on attachment: 426996 Committed r276563 (236999@main): <https://commits.webkit.org/236999@main>
Ryosuke Niwa
Comment 6 2021-04-24 23:00:05 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2021-04-24 23:01:19 PDT
<rdar://problem/77114154>
Note You need to log in before you can comment on or make changes to this bug.