Bug 22502
| Summary: | [Windows] WebCoreGenerated Project Should Support Arguments | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | ||
| Priority: | P3 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Mac | ||
| OS: | Windows XP | ||
Brent Fulgham
The Problem:
=============
The WebCoreGenerated Visual Studio project uses the build-generated-files.sh script to convert various IDL files into C++ implementations. The shell script is hard coded with the following FEATURE_DEFINE values:
ENABLE_DATABASE ENABLE_DOM_STORAGE ENABLE_ICONDATABASE ENABLEOFFLINE_WEB_APPLICATIONS ENABLE_PATH ENABLE_SVG ENABLE_SVG_ANIMATION ENABLE_SVG_FONTS ENABLE_SVG_FOREIGN_OBJECT ENABLE_SVG_AS_IMAGE ENABLE_SVG_USE ENABLE_WORKERS ENABLE_VIDEO
When targeting something like the Cairo variant of the Windows build, we need to exclude the ENABLE_VIDEO to avoid pulling the QuickTime libraries, since they may not be redistributed.
Proposed Solution
============
Modify the build-generated-files.sh so that it takes the FEATURE_DEFINES as an argument so that different configurations in Visual Studio could populate this with different values.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |