| Summary: | Improve parsing and computed style of the rotate CSS property | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | CSS | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2021-04-24 09:10:13 PDT
Created attachment 426983 [details]
Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess Comment on attachment 426983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426983&action=review > LayoutTests/imported/w3c/ChangeLog:14 > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Isn't this the wrong place to make this change? How will it get submitted back to WPT? (In reply to Dean Jackson from comment #3) > Comment on attachment 426983 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426983&action=review > > > LayoutTests/imported/w3c/ChangeLog:14 > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: > > Isn't this the wrong place to make this change? How will it get submitted > back to WPT? I'll make a WPT PR from this patch once it lands. Committed r276554 (236994@main): <https://commits.webkit.org/236994@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426983 [details]. (In reply to Antoine Quint from comment #4) > (In reply to Dean Jackson from comment #3) > > Comment on attachment 426983 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=426983&action=review > > > > > LayoutTests/imported/w3c/ChangeLog:14 > > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: > > > > Isn't this the wrong place to make this change? How will it get submitted > > back to WPT? > > I'll make a WPT PR from this patch once it lands. The PR is up at https://github.com/web-platform-tests/wpt/pull/28691. |