Bug 225019

Summary: Improve parsing and computed style of the rotate CSS property
Product: WebKit Reporter: Antoine Quint <graouts>
Component: CSSAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: clopez, dino, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, koivisto, macpherson, menard, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Antoine Quint
Reported 2021-04-24 09:10:13 PDT
Improve parsing and computed style of the rotate CSS property
Attachments
Patch (26.90 KB, patch)
2021-04-24 09:18 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-04-24 09:18:42 PDT
Created attachment 426983 [details] Patch
EWS Watchlist
Comment 2 2021-04-24 09:19:38 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Dean Jackson
Comment 3 2021-04-24 11:15:25 PDT
Comment on attachment 426983 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=426983&action=review > LayoutTests/imported/w3c/ChangeLog:14 > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: Isn't this the wrong place to make this change? How will it get submitted back to WPT?
Antoine Quint
Comment 4 2021-04-24 11:16:23 PDT
(In reply to Dean Jackson from comment #3) > Comment on attachment 426983 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=426983&action=review > > > LayoutTests/imported/w3c/ChangeLog:14 > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: > > Isn't this the wrong place to make this change? How will it get submitted > back to WPT? I'll make a WPT PR from this patch once it lands.
EWS
Comment 5 2021-04-24 12:36:35 PDT
Committed r276554 (236994@main): <https://commits.webkit.org/236994@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 426983 [details].
Radar WebKit Bug Importer
Comment 6 2021-04-24 12:37:16 PDT
<rdar://problem/77108692>
Antoine Quint
Comment 7 2021-04-26 06:14:55 PDT
(In reply to Antoine Quint from comment #4) > (In reply to Dean Jackson from comment #3) > > Comment on attachment 426983 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=426983&action=review > > > > > LayoutTests/imported/w3c/ChangeLog:14 > > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid-expected.txt: > > > + * web-platform-tests/css/css-transforms/parsing/rotate-parsing-valid.html: > > > > Isn't this the wrong place to make this change? How will it get submitted > > back to WPT? > > I'll make a WPT PR from this patch once it lands. The PR is up at https://github.com/web-platform-tests/wpt/pull/28691.
Note You need to log in before you can comment on or make changes to this bug.